search

Kalagaar / tabgroupsmanager

Automatically exported from code.google.com/p/tabgroupsmanager
0 stars 0 forks source link

multi-row tabs don't work with the betas #69

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Before submitting the issue, please check that your version of TabGroups
Manager is the lastest stable one. (Check it in Firefox Extensions).

What steps will reproduce the problem?
1. Use "multi-row" tabs (i specify this option using tab mix plus)
2. have more than one row of tabs open
3.

What is the expected output? What do you see instead?
Before the betas, you would see multiple rows of tabs.  now, you only see one 
row, and you can't get to any of the tabs on the lower rows.

System Info:
What version of TabGroups Manager are you using?

Tried with both .003 and .004

What Operative System are you using? 32 or 64 bits?

Same behavior on 64bit ubuntu linux and 64bit windows 7.

What version of Firefox are you using?

33

Are you using any other tab extension like Colorfull tabs, Multiple Tab
Handler, TabMix Plus..?

Tab Mix Plus.

Please provide any additional information below and screens capture if
possible.

Original issue reported on code.google.com by jahlborn@gmail.com on 20 Oct 2014 at 12:53

GoogleCodeExporter commented 9 years ago 
Note that issue 53 also seems to be related to this, as i see that as well when 
i switch to other tab groups from the first.

Original comment by jahlborn@gmail.com on 20 Oct 2014 at 12:55

GoogleCodeExporter commented 9 years ago 
Any TGM related failure messages in console?
Latest TMP version is installed?

Original comment by micha.go...@arcor.de on 21 Oct 2014 at 3:21

GoogleCodeExporter commented 9 years ago 
i'm using the latest released version of TMP.

I don't have a huge amount of experience using the browser console, but i don't 
see any errors pop up when i switch on and off the multi-row support.

Original comment by jahlborn@gmail.com on 21 Oct 2014 at 6:35

GoogleCodeExporter commented 9 years ago 
Please advise currently installed TMP version number and try latest dev build 
tab_mix_plus-0.4.1.6pre.141014a2.xpi. If its not working you can install your 
previous version of TMP.

Original comment by micha.go...@arcor.de on 22 Oct 2014 at 9:38

GoogleCodeExporter commented 9 years ago 
I'm currently using TMP 0.4.1.5.2.  i'll try the dev build and see what happens.

Original comment by jahlborn@gmail.com on 22 Oct 2014 at 12:55

GoogleCodeExporter commented 9 years ago 
Same behavior with TMP 0.4.1.6pre.141014a2.

Original comment by jahlborn@gmail.com on 22 Oct 2014 at 1:01

GoogleCodeExporter commented 9 years ago 
@Miguel 

There is indeed a problem with betas and multirow tabs. I have seen the "one 
line" tab row and i have seen a 2nd problem with multirow tabs with much tabs 
in first group.

I have not import all changes to my tgm code and on my side it looks ok.

So i have not experienced any TMP multirow tab problems in the past and I use 
it in Nightlies every day.

I have it not yet tested, but maybe it are the removeAtrribute hidden related 
stuff for compatibility reasons for old TGM versions? I have never understand 
this changes and so i have it ignored until now. Need further investigations 
here.

Original comment by micha.go...@arcor.de on 22 Oct 2014 at 8:05

Attachments:

GoogleCodeExporter commented 9 years ago 
@Miguel

Have copied the entire tab hidden to colapsed related code to my version and 
Multirow works also in my version not satisfied. You should remove it and 
revert to original code here.

Original comment by micha.go...@arcor.de on 22 Oct 2014 at 8:51

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
hi micha, thank you so much, really nice to know. However the hidden atribute 
made some bugs with tabs in TGM as shown here:
http://xuldev.blogspot.com.es/2007/09/how-to-hide-tab-correctly-difference.html

The fix was set in 002 version, in this commit:
https://code.google.com/p/tabgroupsmanager/source/detail?r=74

Now that we know the cause, it will be really easy either to revert the code or 
even to implement another third solution to fix both problems.

Original comment by miguelro...@gmail.com on 22 Oct 2014 at 10:00

GoogleCodeExporter commented 9 years ago 
https://developer.mozilla.org/en-US/Add-ons/Overlay_Extensions/Firefox_addons_de
veloper_guide/Introduction_to_XUL%E2%80%94How_to_build_a_more_intuitive_UI

Original comment by miguelro...@gmail.com on 22 Oct 2014 at 10:09

GoogleCodeExporter commented 9 years ago 
If i read the definitions, the hidden attribute makes more sense. With 
collapsed the Element is still there, but without dimensions. So i suspect this 
will cause problems. The culprit is TGM is no standalone scenario. TGM have to 
deal with Fx panorama and with 3rd party addons as TMP, TU. All playing in the 
tab management playground.

If one party handle this in another way, you will run into chaos. I suspect 
this is exactly what is happening here. How does manage this Fx panorama self? 
Does mozilla use hide or collapse? And what does TMP? I had no time to 
investigate still TMP, TU or Panorama additionally to TGM, so i decided to let 
it as it is as long it works.

Original comment by micha.go...@arcor.de on 23 Oct 2014 at 8:54

GoogleCodeExporter commented 9 years ago 
Hi @micha. Can you post your version with working multirow?

Original comment by bartosz...@gmail.com on 26 Nov 2014 at 2:37

GoogleCodeExporter commented 9 years ago 
Hi everyone, sorry for the bad english. I'm not a programmer, but dug into the 
code, and something has achieved. At the moment I have correctly works function 
"multiple row" with firefox 35. I would be happy if it would benefit.

p.s. The string number 1652 in the file TabGroupsManager.js returned to its 
original form.

Dmitry.

Original comment by dmvoron...@gmail.com on 15 Dec 2014 at 11:11

Attachments:

GoogleCodeExporter commented 9 years ago 
Thank you @dmvoron. Multirow works for me in firefox 34 and i don't see 
anything broken

Original comment by bartosz...@gmail.com on 16 Dec 2014 at 12:21

GoogleCodeExporter commented 9 years ago 
Thank you for the comments and fix. Micha fixed it some weeks ago but I havent 
been able to test it and to release a new version. I will try to do it as soon 
as possible. 

I will need to ask Mozilla about it, since there was an issue with the hidden 
attribute which made tabs to dissapear.

Thanks.

Original comment by miguelro...@gmail.com on 16 Dec 2014 at 1:52

GoogleCodeExporter commented 9 years ago 
Micha and dmvoron, I just tested the lastest code at the svn with all the 
lastest micha fixes and it still broken. Some tabs to dissapear after moving 
them to other groups or after moving them in the same group.

The bug with "hidden" attribute for tabs is still there and hasnt been fixed by 
Mozilla. 
Please check my attached NON FIXED version with the bug still there if you want 
to play with it. 

**We cant use hidden attribute on tabs until its fixed.**

I will write to Mozilla and to TabMixPlus to see how we can solve it. I will 
add more details soon.

Original comment by miguelro...@gmail.com on 16 Dec 2014 at 11:33

Attachments:

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
It has been never fixed, look here please:
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/tab

They say us to use collapsed instead of hidden O_O

In that casem TabMixPlus should change their behavior and management of tabs 
and also support collapsed attribute.

Original comment by miguelro...@gmail.com on 16 Dec 2014 at 11:50

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Wrote to the generic TabMixPlus support email, since I cant register in their 
form (never receive the account confirmation email). Lets see if we receive an 
answer and write to Mozilla for support with this bug.

Original comment by miguelro...@gmail.com on 17 Dec 2014 at 12:12

GoogleCodeExporter commented 9 years ago 
more info of the issue with TabMixPlus:
https://github.com/Infocatcher/Private_Tab/issues/95
https://bitbucket.org/onemen/tabmixplus/issue/11/compatibility-problem-of-multi-
row-feature

Original comment by miguelro...@gmail.com on 17 Dec 2014 at 12:40

GoogleCodeExporter commented 9 years ago 
Do you have a way to reproduce this? I have never seen disappeared tabs.

Original comment by micha.go...@arcor.de on 20 Dec 2014 at 12:29

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
fixed the issue with hidden attribute and cmopatible with TabMixPlus, details 
and new release soon in some hours :)

Original comment by miguelro...@gmail.com on 21 Dec 2014 at 10:09

GoogleCodeExporter commented 9 years ago 
new version released 005 compatible with TabMixPlus and fixed the tabs 
dissapearing bug, among many other fixes and improvements added by micha. Thank 
you all and specially Onemen (developer from TabMixPlus) for the support with 
some issues. 

You can download the new version in the frontpage: 
https://code.google.com/p/tabgroupsmanager

Changelog
---------

[2014.12.21]:
- Name: Lastest - TGM 005.
- Version: 2014.12.21.005
- File: addon-2014.12.21.005-fx.xpi
- Issue: 
- Changes:
Fixed bug with 'hidden' attribute which caused incompatibility with TabMixPlus. 
Now multirow works! :) (Thanks micha and Onemen (TMP developer) for all your 
help). 
We have reverted from 'collapsed' to 'hidden' doing it the right way: 
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xm
l
Fixed in Firefox >25 SessionStore initialize with promise 
initializeAfterOnLoad(), instead of the temporary fix patch. (fixed by micha. 
Thanks to Onemen (TMP developer) for support in this matter). 
Fixed tab.group is not defined at startup since Fx25+, with new promise future. 
In FX25+ is mandatory (fixed by micha).
Fixed SessionManager to TabmixSessionManager to get rid off depreciated message 
(fixed by micha).
Added debug output to empty catch, so we get info for loadAllGroupsData() in 
debug mode (micha).
Added spaces between transparency tab groups for personas themes to overlay.css 
(micha).

You

Original comment by miguelro...@gmail.com on 22 Dec 2014 at 12:23

GoogleCodeExporter commented 9 years ago 
Thank you so much. ;)

About that: Fixed SessionManager to TabmixSessionManager to get rid off 
depreciated message (fixed by micha).

Should I turn on TabmixSessionManager?
Or should i turn on "override the method of "restore sesion"" in TGM.
Or maybe both?

I dont use addon session manager. Only TMP and TGM.
Whats is the best settings?

Original comment by bartosz...@gmail.com on 22 Dec 2014 at 2:26

GoogleCodeExporter commented 9 years ago 
I dont really know, I have always used default Firefox session manager. 
Probably with that fix, TabMixPlus Session Manager also works, and you have 
more advanced options than with the default Firefox one.

Original comment by miguelro...@gmail.com on 22 Dec 2014 at 7:46

GoogleCodeExporter commented 9 years ago 
The fix was related to a TGM call to a Tabmix function. The old interface is 
still provided, but we got the message from tmp that it is depreciated. So it 
works as before, only without a failure message. If you have tmp sessionmanager 
not used until now, there is no reason to use it now. 

TMP has extended sessionstore possibilties. I use TGM self for this, there is 
also a session store function in group bar context menu.

Original comment by micha.go...@arcor.de on 22 Dec 2014 at 9:54

GoogleCodeExporter commented 9 years ago 
awesome!  so far, so good...

Original comment by jahlborn@gmail.com on 23 Dec 2014 at 3:10

GoogleCodeExporter commented 9 years ago 
Revision: r250 

it is better to use tabbrowser.xml functions gBrowser.hideTab(tab) and 
gBrowser.showTab(tab), then to copy both functions to 
TabGroupsManager.utils.hideTab and TabGroupsManager.utils.unHideTab

Original comment by hadar.ha...@gmail.com on 26 Dec 2014 at 7:44

GoogleCodeExporter commented 9 years ago 
Yes, totally agree hadar. Just wanted to be sure the code was working fine. I 
will change it for the next release and use all gBrowser functions directly. 
Thanks.

Original comment by miguelro...@gmail.com on 28 Dec 2014 at 8:20

GoogleCodeExporter commented 9 years ago 
Changed it to gBrowser functions and its working properly.

Original comment by micha.go...@arcor.de on 21 Feb 2015 at 2:16