search

Kalamandea / Rikaichan

Rikaichan is a popup Japanese-English/German/French/Russian dictionary tool
GNU General Public License v2.0
52 stars 10 forks source link

Only shows character-per-character definition #2

Closed nicolas-raoul closed 7 years ago

nicolas-raoul commented 7 years ago

When hovering the mouse over 日本 the add-on should show the definition of 日本 not the definition of 日

screenshot from 2017-11-22 15-43-51

This happens on all websites I have tried (Nikkei, Google, Gmail).

I have the default options right after installing the addon: screenshot from 2017-11-23 14-45-36

By the way, the last 3 reviews are about this problem: screenshot from 2017-11-23 14-49-06

SavannahJohnston commented 7 years ago

There are multiple modes for Rikaichan hover and lookup. Check if you have all of them activated. If so, you can press shift to alternate between them.

nicolas-raoul commented 7 years ago

I have the default settings, I believe, as I haven't touched any configuration since I installed the add-on. I had Rikaichan/Rikaikun/Perapera but I guess these used separate settings. I add my options to the issue report above, do you know which one is wrong and what value it should have instead? Thanks!

markus07 commented 7 years ago

You need to add dictionary, default is only Kanji. But when I download and tried to add Japanese-English dictionary got this error Error: TypeError: summary is null

nicolas-raoul commented 7 years ago

Ah indeed thanks @markus07! I get this error too, for the 3 dictionaries I tried: screenshot from 2017-11-24 12-18-02 The problem might be in this function: https://github.com/Kalamandea/Rikaichan/blob/dd4c14012c1204fcff443d0ab9accaaae920d701/ext/bg/js/databaseRikai.js#L66 According to StackOverflow:

"TypeError: [x] is null" - [...] the most common reason a JavaScript developer will get this is that they are trying to assign an event handler to a DOM element, but the DOM element hasn't been created yet.

michaelmmason commented 7 years ago

I have the same issue with dictionary imports, so I've opened it as a separate issue.

I was able to import dictionaries the last time I tried, which was a week or two ago. As @markus07 says, it fixes the problem @nicolas-raoul reported and Rikaichan works more-or-less the same way it used to.

nicolas-raoul commented 7 years ago

When #3 is fixed, the present problem should be fixed too.