Kaldek / rat-ratgdo

Open source schematics for ratgdo PCB
MIT License
306 stars 47 forks source link

Cleanup files for Gerber builds #42

Closed dolfelt closed 8 months ago

dolfelt commented 8 months ago

I've updated the markdown and added the bare schematic to the builds. Let me know what you think.

Kaldek commented 8 months ago

I've updated the markdown and added the bare schematic to the builds. Let me know what you think.

Just checking this request and it looks like modifications of text in the markdown files and removal of files from the Gerber folder only?

dolfelt commented 8 months ago

Yep!

Kaldek commented 8 months ago

Sorry mate, my actual question is "why". 😁

dolfelt commented 8 months ago

@Kaldek I removed all the Gerber files since they are now built with the Github Actions directly. This means there is less to commit and review in pull requests, and one less step to remember when updating the KiCad files.

As for the Markdown changes, I fixed a broken image link and maybe got carried away removing the hardcoded URL so that forks/pull requests can reference items local to their own repository before merging into the main one. My editor also removes trailing spaces, which is what some of those big block are. I didn't change any actual text in the Markdown.

Hope this was a decent explanation. 😅

Kaldek commented 8 months ago

Ah right, OK my noobiness shines through here; I didn't know it was possible for the files to be built automatically. I am literally 3 weeks into Github, which is as embarrassing to me as it probably is to everyone else.

dolfelt commented 8 months ago

@Kaldek It doesn't show at all, and is impressive how much you've done in only 3 weeks! 👍