search

KalebDark / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

dEQP AOSP Integration #901

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
We should make the dEQP package available on the AOSP our main source for 
testing, and enable all users to test with dEQP.

dEQP repo URL: https://android.googlesource.com/platform/external/deqp

We're currently using the branch "deqp-dev".

Original issue reported on code.google.com by jmad...@chromium.org on 29 Jan 2015 at 9:41

GoogleCodeExporter commented 9 years ago

Original comment by shannonw...@chromium.org on 29 Jan 2015 at 10:23

GoogleCodeExporter commented 9 years ago 
We should also make sure to add instructions to the wiki on how to use dEQP 
with ANGLE.

Original comment by shannonw...@chromium.org on 29 Jan 2015 at 10:24

GoogleCodeExporter commented 9 years ago 
Current WIP CL:

https://chromium-review.googlesource.com/#/c/238084/

Current items to do:

 * fix 64 bit and Release builds, possibly by contributing to AOSP
 * work with Pyry to figure out the proper way to include eglext.h
 * figure out the best way to copy data files or set working dir
 * run a full test pass without crashes, asserts or hangs
 * (later): chromium bot integration

Original comment by jmad...@chromium.org on 30 Jan 2015 at 9:46

GoogleCodeExporter commented 9 years ago 
The [[flatten]] bug is causing a TDR when you run the GLES2 or GLES3 tests in 
Windows in 
functional.shaders.loops.for_constant_iterations.infinite_with_conditional_break
_*. Would be nice to fix this before we push it.

Original comment by jmad...@chromium.org on 9 Mar 2015 at 3:29

GoogleCodeExporter commented 9 years ago 
Also worth noting I'm seeing a timeout in 
dEQP-GLES2.functional.fbo.render.recreate_colorbuffer.rebind_rbo_rgb565_stencil_
index8. Need to investigate.

Original comment by jmad...@chromium.org on 9 Mar 2015 at 3:44

GoogleCodeExporter commented 9 years ago 
issue 942 is causing a leak in dEQP, could be why the above test hanged on my 
full pass.

Original comment by jmad...@chromium.org on 11 Mar 2015 at 3:35

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 87de3627de25d2915ca892f560a3b840318de244

Code-Review  0 : Brandon Jones, Jamie Madill, Zhenyao Mo
Code-Review  +2: Geoff Lang
Verified     0 : Brandon Jones, Geoff Lang, Zhenyao Mo
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I0ce0258b0e91eb83c066c241693aaa5c164b2989
Reviewed-at    : https://chromium-review.googlesource.com/257131

Implement pass-through pack state params.

Same as for unpack, this allows us to pass through the state reset
code of dEQP without UNIMPLEMENTED errors, while still throwing
asserts if they are set to non-default values.

BUG=angleproject:901,angleproject:512

src/libANGLE/State.cpp
src/libANGLE/State.h
src/libANGLE/angletypes.h
src/libANGLE/renderer/d3d/FramebufferD3D.cpp
src/libANGLE/renderer/gl/FramebufferGL.cpp
src/libGLESv2/entry_points_gles_2_0.cpp

Original comment by bugdro...@chromium.org on 16 Mar 2015 at 5:32

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 67102f01dc6a606c65a05121c61dc6630423ab3c

Code-Review  0 : Brandon Jones, Jamie Madill, Zhenyao Mo
Code-Review  +2: Geoff Lang
Verified     0 : Brandon Jones, Geoff Lang, Zhenyao Mo
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I3bd35f6dea61e7d80d1379ba4e8e13437e68431a
Reviewed-at    : https://chromium-review.googlesource.com/257130

Add pass-through for new unpack store params.

Move the UNIMPLEMENTED checks to where they are used with non-default
values. This allows dEQP to pass the prerequisite tests like state
reset without throwing assertion failures in debug.

BUG=angleproject:901,angleproject:512

src/libANGLE/State.cpp
src/libANGLE/State.h
src/libANGLE/angletypes.h
src/libANGLE/renderer/d3d/TextureD3D.cpp
src/libANGLE/renderer/gl/TextureGL.cpp
src/libGLESv2/entry_points_gles_2_0.cpp

Original comment by bugdro...@chromium.org on 16 Mar 2015 at 5:32

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 3cd438d107c9e2daba2cff8c8b8a715488199c69

Code-Review  0 : Jamie Madill, Zhenyao Mo
Code-Review  +1: Kenneth Russell, Olli Etuaho
Code-Review  +2: Geoff Lang
Verified     0 : Geoff Lang, Kenneth Russell, Olli Etuaho, Zhenyao Mo
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : Ib6fe66041a6fe547eb2cba497c52de7fd080d667
Reviewed-at    : https://chromium-review.googlesource.com/238084

Add dEQP tests.

We integrate dEQP as a console application and a shared library which
runs all of the test logic. Using a shared library lets us compile
dEQP with all the specific compiler options it needs, without
conflicting with the compile settings in ANGLE proper.

Currently we only support Windows D3D11, ES 2 and 3. We can add
other targets in the future.

We also have a few bugs preventing us from running the test suite in
full. We run into infinite loop problems in some shader tests, and
have crashes or UNIMPLEMENTED in others.

BUG=angleproject:901

.gitignore
DEPS
src/tests/deqp.gypi
src/tests/deqp_support/angle_deqp_libtester_main.cpp
src/tests/deqp_support/angle_deqp_tests_main.cpp
src/tests/deqp_support/tcuANGLEWin32NativeDisplayFactory.cpp
src/tests/deqp_support/tcuANGLEWin32NativeDisplayFactory.h
src/tests/deqp_support/tcuANGLEWin32Platform.cpp
src/tests/deqp_support/tcuANGLEWin32Platform.h
src/tests/tests.gyp

Original comment by bugdro...@chromium.org on 24 Mar 2015 at 3:25

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 2a7ffe163c7a41c93ea482704b670f21534fb1b7

Code-Review  0 : Jamie Madill, Olli Etuaho
Code-Review  +1: Austin Kinross, Geoff Lang
Code-Review  +2: Brandon Jones
Verified     0 : Austin Kinross, Brandon Jones, Geoff Lang, Olli Etuaho
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : Ia8dc77466bd32f0b8b0d638ae839f41288bfe25b
Reviewed-at    : https://chromium-review.googlesource.com/266889

Add ANGLE platform selection for dEQP.

This gives us the choice between D3D9 and D3D11. We can add more
platforms easily using the same patterns.

BUG=angleproject:901

src/tests/deqp.gypi
src/tests/deqp_support/tcuANGLEWin32NativeDisplayFactory.cpp
src/tests/deqp_support/tcuANGLEWin32NativeDisplayFactory.h
src/tests/deqp_support/tcuANGLEWin32Platform.cpp

Original comment by bugdro...@chromium.org on 24 Apr 2015 at 9:02

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : a7441353d1c1827dd238a30a7e98a88d335b8936

Code-Review  0 : Jamie Madill
Code-Review  +1: Geoff Lang
Code-Review  +2: Brandon Jones
Verified     0 : Brandon Jones, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I9de5b055dcfe4ad5c13c800a31b4a0b424863bee
Reviewed-at    : https://chromium-review.googlesource.com/266888

Fix missing texture target validations.

We were missing this in a few places, and this was giving runtime
errors in dEQP negative tests.

BUG=angleproject:901

src/libGLESv2/entry_points_gles_2_0.cpp

Original comment by bugdro...@chromium.org on 27 Apr 2015 at 3:08

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 84115c9294c0c8656b00e4215bd505a444eb970c

Code-Review  0 : Jamie Madill
Code-Review  +1: Geoff Lang
Code-Review  +2: Brandon Jones
Verified     0 : Brandon Jones, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I2b3c04752d1df3289d41c013cc936eda30e98aad
Reviewed-at    : https://chromium-review.googlesource.com/266927

Keep default FBO attachments immutable.

In some cases we would let the user change the attachments of the
default FBO. This hole in our validation would confound the dEQP
negative API tests (negative_api.buffer.framebuffer_*) and muck
up the remainder of the test run.

BUG=angleproject:901

src/libANGLE/validationES.cpp

Original comment by bugdro...@chromium.org on 27 Apr 2015 at 3:09

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 0be9a8a03a8c313d318344b696b3984c59e1b827

Code-Review  0 : Jamie Madill
Code-Review  +1: Geoff Lang
Code-Review  +2: Brandon Jones
Verified     0 : Brandon Jones, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I9888c1aca851519e9c7da210c983ba6012e95932
Reviewed-at    : https://chromium-review.googlesource.com/266926

No-op BufferSubData after validation.

We were skipping some validation, which was confusing dEQP. We can
still no-op, but do this after all validation.

BUG=angleproject:901

src/libGLESv2/entry_points_gles_2_0.cpp

Original comment by bugdro...@chromium.org on 27 Apr 2015 at 3:09

GoogleCodeExporter commented 9 years ago 
Wrote up the wiki page here: https://code.google.com/p/angleproject/wiki/dEQP

Original comment by jmad...@chromium.org on 27 Apr 2015 at 8:23

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 3da79b7bca0bb780dfe60db7bec4c5dd9d627ff8

Code-Review  0 : Jamie Madill
Code-Review  +1: Geoff Lang
Code-Review  +2: Brandon Jones
Verified     0 : Brandon Jones, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I6906d3345abe9f89cfa0aa6cec4be26b5b2851d0
Reviewed-at    : https://chromium-review.googlesource.com/266928

Reject shaders using attribute aliasing.

The current code rejects any shaders that use more than the caps
allow, but a bug would crash us before the check. We don't support
aliasing in shaders that use a lot of uniforms because this
causes problems with the D3D back-end, currently. This changes the
crash in the dEQP aliasing tests to a link error.

See dEQP-GLES2.functional.attribute_location.bind_aliasing.*

BUG=angleproject:901

src/libANGLE/Program.cpp
src/libANGLE/Program.h
src/libANGLE/renderer/ProgramImpl.cpp
src/libANGLE/renderer/ProgramImpl.h
src/libANGLE/renderer/d3d/DynamicHLSL.cpp
src/libANGLE/renderer/d3d/DynamicHLSL.h
src/libANGLE/renderer/d3d/ProgramD3D.cpp
src/libANGLE/renderer/gl/ProgramGL.cpp

Original comment by bugdro...@chromium.org on 28 Apr 2015 at 7:24

GoogleCodeExporter commented 9 years ago 
Marking as Fixed, will open new issues for further dEQP improvements.

Original comment by jmad...@chromium.org on 28 Apr 2015 at 7:24