search

KalebDark / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Refactor Program's InfoLog to use std::stringstream #992

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
This would be a much better fit than using vsprintf and allocating 
re-allocating buffers.

Original issue reported on code.google.com by jmad...@chromium.org on 1 May 2015 at 2:28

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 8ae74e11d2105104737a7425e3bdd68e6329dcfa

Code-Review  0 : Geoff Lang, Jamie Madill
Code-Review  +2: Brandon Jones
Verified     0 : Brandon Jones, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I6328cd03901dbf52eccddc7c747a684ed9b23ea1
Reviewed-at    : https://chromium-review.googlesource.com/268741

Use a std::stringstream for Program's InfoLog.

This should help WebKit avoid needing to apply a local patch.
Also clean up the style in this file a bit.

BUG=angleproject:307,angleproject:992

src/libANGLE/Program.cpp
src/libANGLE/Program.h

Original comment by bugdro...@chromium.org on 4 May 2015 at 6:05