Kalebu / alright

Python wrapper for WhatsApp web-based on selenium
https://www.youtube.com/watch?v=yitQTt-NukM
MIT License
368 stars 110 forks source link

option to create headless chrome #120

Closed fierylion closed 1 year ago

fierylion commented 1 year ago

This pull request adds a new option to enable headless mode in Chrome for the alright library. The new option is called headless and can be set to True or False.

To implement this feature, I updated the WhatsApp class to accept a new headless argument in the init method. If the headless argument is set to True, the --headless argument is added to the Chrome options.

Overall, this feature should provide a more flexible and customizable experience for users of the alright library who want to run Chrome in headless mode.

badi95 commented 1 year ago

How do you handle the qr code authentication when running headless?

fierylion commented 1 year ago

Hello, Thanks for reviewing my PR, Because qr code verification is a one time process, Then it is much easier for users to run non headless once then every other time they have an option to run headless or non headless.

On Tue, Apr 11, 2023 at 5:43 PM badi95 @.***> wrote:

How do you handle the qr code authentication when running headless?

— Reply to this email directly, view it on GitHub https://github.com/Kalebu/alright/pull/120#issuecomment-1503503882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXKXR6EOI3WAXQHXHD2CSU3XAVUZFANCNFSM6AAAAAAW2IXLX4 . You are receiving this because you authored the thread.Message ID: @.***>

Kalebu commented 1 year ago

Hello @fierylion, Did you test it and It actually worked?

fierylion commented 1 year ago

Thank you @Kalebu for considering my PR, I can assure you that I ran multiple tests and it doesn't break any functionality. It works perfectly and enables qr code logged in user to have options (whether they want to run the program in headless or non headless mode)