search

Kaleido-subs / Kaleidosubs

Subtitles for [Kaleido-subs]
https://kaleido.kageru.moe/
8 stars 3 forks source link

Kimetsu no Yaiba Ep. 20 - Grammar error #5

Closed SuperfieldCU closed 3 years ago

SuperfieldCU commented 3 years ago

Line 90: Do you want me save you?

->

Do you want me to save you?

The0x539 commented 3 years ago

Fixed in the internal project repo since 2021-02-25.

LightArrowsEXE commented 3 years ago

Will merge for now. The Yaiba directory will be removed from here once the project repository is public (which will be once we release the final batch)

EDIT: nvm I thought this was a PR but it's not 🙃

SuperfieldCU commented 3 years ago

I tried to make a PR for it, but it wouldn't let me.

I obviously don't know the status of your internal files, but there's another error I found in the public version: episode 14's Sign style has its anchoring set to 2 instead of 5 like all the others. That in and of itself isn't a problem, I'm sure it was for some of the complex signs in that episode, but it also incorrectly offset the Demon Slayer logo in the OP. An {\an5} tag should be added to that line in the internal project if it hasn't already.

The0x539 commented 3 years ago

At some point, I went through and made sure that all instances of each style are the same throughout the project (ironing out the differences was a bit of a headache, but hey): image

In addition, we set things up so that each episode has separate dialogue and TS files that get merged while muxing, as well as one shared subtitle file for the OP and one for the ED that get timeshifted for each episode, so everything about those (including the sign, because Light decided to put that in the shared OP file) should be identical across episodes.

I probably inadvertently messed up some other stuff in the process (I've definitely caught several of my own mistakes), but I've done a lot of work with leveraging technology to try and produce consistency or, barring that, at least checking for consistency (e.g., that image above, where it's clear that there are no longer slightly-different versions of style definitions, or making sure that all the PREVIEW signs are consistent and not messed up).

Fun fact: The preview background for episodes 2-5 is positioned differently from episode 6 onward, and episode 4 uses a third unique position after the closeup shot of Tanjirou for the Taisho secret.

Another fun fact: episode 2, episodes 3-5, and episode 6 onward each use a slightly different shot for the つづく shot at the end of each episode. I discovered this when trying to clean up that TS and establish a single source of truth for how that sign should be typeset. Instead, we now have a triple source of truth. Better than 22, I guess?