search

Kalela / BrightEvents

Bright Events API for Event Management.
https://brighteventsapinowlive.herokuapp.com
0 stars 0 forks source link

Ft better ui and logic 153324164 #8

Closed Kalela closed 6 years ago

Kalela commented 6 years ago

What does this PR do?

Switches the project folder structure

How should this be manually tested?

Tested by pushing local project to github. Travis CI checks provided tests if Build is working.

What are the relevant pivotal tracker stories?

Create tests for upcoming functionality ID: #153294351

ebrahim-j commented 6 years ago

Haven't gone through your code but I'm not sure why we have so much being done on this branch.. Ideally, new code added/ edited/ removed must directly be linked to what the branch name is, so unless all these commits are UI and logic only, then it's too much being done. Also the branch name would probably need to be less vague(for the next branches) and have some sort of indication of what specifically is being worked on eg ft_user_auth_logic rather than just ft_logic if you're working on user authorization logic.. Lastly, I would recommend that PR's have just a handful of files being changed as it would be easier for reviewing purposes

Kalela commented 6 years ago

Got it. I'll make branches less ambiguous from now on.