Kalmat / PyWinCtl

Cross-Platform module to get info on and control windows on screen
Other
180 stars 19 forks source link

Update pyrightconfig and unused ignore comments #33

Closed Avasam closed 1 year ago

Avasam commented 1 year ago

Just a small update now that pyright allows completely ignoring type: ignore comments (leaving them to mypy).

Kalmat commented 1 year ago

So sad I just drafted a new realease and uploaded a new version to PyPi!!! Well, this will be included in next version.

Thank you again!

Avasam commented 1 year ago

Don't worry, it does not affect anything on the users' side. It's just a dev tool update for pywinctl

Kalmat commented 1 year ago

👍

El mié, 7 dic 2022 a las 20:55, Avasam @.***>) escribió:

Don't worry, it does not affect anything on the users' side.

— Reply to this email directly, view it on GitHub https://github.com/Kalmat/PyWinCtl/pull/33#issuecomment-1341512379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJPDFMKS3JG2G4HKAUGVSFTWMDTTFANCNFSM6AAAAAASXG5NSE . You are receiving this because you modified the open/close state.Message ID: @.***>

Kalmat commented 1 year ago

Hi again! Just a little issue when you have time. I uploaded a new module version (thank you for your reaction!), but it complains with "ModuleNotFoundError: No module named typing_estensions". I then tried to fix it uploading a new version, but with no success (I'm afraid I forgot to properly modify the setup.py file). Anyway, I understood typing_extensions (like mypy or types-setuptools) was required only for development, not in run-time. Is this correct? If so, how can I fix it? If not, I guess I should upload a new version (0.0.42) to include this module within setup.py requirements to avoid the error when installing pywinctl using pip (I should call it "brown paper bag version" HAHAHAHA!)

Thank you!

El mié, 7 dic 2022 a las 20:56, Kalma @.***>) escribió:

👍

El mié, 7 dic 2022 a las 20:55, Avasam @.***>) escribió:

Don't worry, it does not affect anything on the users' side.

— Reply to this email directly, view it on GitHub https://github.com/Kalmat/PyWinCtl/pull/33#issuecomment-1341512379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJPDFMKS3JG2G4HKAUGVSFTWMDTTFANCNFSM6AAAAAASXG5NSE . You are receiving this because you modified the open/close state.Message ID: @.***>

Avasam commented 1 year ago

To avoid having typing_extensions be a runtime requirements. You can do the following:

from typing import Any
try:
  from typing_extensions import Literal
except ImportError:
  Literal = Any # Only needed if the import from typing_extensions is used outside of annotations

OR

from typing import Any, TYPE_CHECKING
if TYPE_CHECKING:
  from typing_extensions import Literal
else:
  Literal = Any # Only needed if the import from typing_extensions is used outside of annotations
Kalmat commented 1 year ago

Thank you! "Brown paper bag" version is coming... Hahaha!

El sáb, 10 dic 2022 2:03, Avasam @.***> escribió:

To avoid having typing extensions be a runtime requirements. You can do the following:

from typing import Anytry: from typing_extensions import Literalexcept ImportError: Literal = Any # Only needed if the import from typing_extensions is used outside of annotations

OR

from typing import Any, TYPE_CHECKINGif TYPE_CHECKING: from typing_extensions import Literalelse: Literal = Any # Only needed if the import from typing_extensions is used outside of annotations

— Reply to this email directly, view it on GitHub https://github.com/Kalmat/PyWinCtl/pull/33#issuecomment-1344956437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJPDFMPW32NMXG5WHXC3DKTWMPJHLANCNFSM6AAAAAASXG5NSE . You are receiving this because you modified the open/close state.Message ID: @.***>