search

Kalmat / PyWinCtl

Cross-Platform module to get info on and control windows on screen
Other
179 stars 19 forks source link

Add window bbox property #39

Closed MestreLion closed 1 year ago

MestreLion commented 1 year ago

as discussed in #37

this includes the commits for #38 , because I was too lazy to properly rebase each PR to the same base (sorry), so wait until you merge #38 before you merge this.

Kalmat commented 1 year ago

Same problem related to typing checks... In this case I think (hope) it's enough changing all those "float" related to rect and box values to "int"

MestreLion commented 1 year ago

this includes the commits for #38 , because I was too lazy to properly rebase each PR to the same base (sorry), so wait until you merge #38 before you merge this.

I've updated the branch so it is based on master and thus independent of #38

Will shortly fix these typing mismatches

MestreLion commented 1 year ago

Same problem related to typing checks... In this case I think (hope) it's enough changing all those "float" related to rect and box values to "int"

Where did you see the errors? It looks like no tests were run, as it's still waiting for your approval

Kalmat commented 1 year ago

I hope I didn't mess with all these PRs. I'm a complete newbie in these tasks!

MestreLion commented 1 year ago

I hope I didn't mess with all these PRs. I'm a complete newbie in these tasks!

So far, so great! The activate() PR has finally passed the tests, now I'll focus on this last one.

I think this will be tough due to the "black-magic" of typing as float in a Rect that only accepts ints. Hopefully I'll find a way that does not require to remove all those cast(float) (yet)