Kalyvara / NXTheme-CHROMA

A collection of sleek themes for Nintendo Switch featuring multiple palettes and layouts
8 stars 3 forks source link

Title alignment for game cards is off center #5

Open EzWiz21 opened 1 month ago

EzWiz21 commented 1 month ago

Hey nice work on CHROMA, I really like how it looks!

I noticed an issue that the alignment of game titles is off for physical game copies where the alignment is shifted to the left when its first on the list and to the right for the second game and onwards. The cartridge icon is also missing.

First on the list 2024071514502800_s

Second and onward 2024071514504100_s

Kalyvara commented 1 month ago

Hi,

This might sound dumb but the alignment of game labels is one of the trickiest things to properly adjust as it requires extensive trial and error. The position is hardcoded and offsets are handled dynamically, and I have no control over that unfortunately. The current position is the best compromise I found from my testing. Any more tampering would inevitably fuck up all the titles.

As for the cartridge icon, I should be able to restore it. I'll push an update whenever possible.

EzWiz21 commented 1 month ago

I actually managed to fix the alignment issues myself (through trial and error of course lol), with the only compromise that the game label is now a little narrower to give enough space for the game card icon to fit in.

All it took was to set a custom X position for N_Card under RdtBalloon and by doing that it keeps the alignment consistent whether the physical title is first on the list or not.

image

image

I'll send the code here later when I'm near my computer.

Kalyvara commented 1 month ago

Ah, interesting. This might very well be an oversight on my part lol. I think it might still act funny depending on the first game displayed but if it stays consistent through and through, that's cool. Trying to fit in those labels is one of the most annoying parts of the process for me tbh.

EzWiz21 commented 1 month ago

Here are the changes I made. It also includes the code that changes the icon color, and you can do the same for All Apps.

diff --git a/v1-1-crashfix/chroma_home_default_sidebar.json b/v1-1-crashfix/chroma_home_default_sidebar.json
index 26feb23..26fd004 100644
--- a/v1-1-crashfix/chroma_home_default_sidebar.json
+++ b/v1-1-crashfix/chroma_home_default_sidebar.json
@@ -3104,21 +3075,38 @@
             "Patches": [
                 {
                     "PaneName": "N_Size",
+                    "Position": {
+                        "X": 130
+                    },
                     "Size": {
-                        "X": 284,
+                        "X": 264,
                         "Y": 42
-                    },
+                    }
+                },
+                {
+                    "PaneName": "N_Card",
                     "Position": {
-                        "X": 78
+                        "X": 16
                     }
                 },
                 {
                     "PaneName": "P_Card",
-                    "Position": {
-                        "X": 9999,
-                        "Y": 9999
-                    },
-                    "Visible": false
+                    "UsdPatches": [
+                        {
+                            "PropName": "C_W",
+                            "PropValues": [
+                                "0",
+                                "0",
+                                "0",
+                                "0"
+                            ],
+                            "type": 2
+                        }
+                    ],
+                    "ColorTL": "FF121212",
+                    "ColorTR": "FF121212",
+                    "ColorBL": "FF121212",
+                    "ColorBR": "FF121212"
                 },
                 {
                     "PaneName": "P_Color",
Kalyvara commented 1 month ago

I can make you a contributor of this repo so you can PR your revised code if you're fine with it.

EzWiz21 commented 1 month ago

Sure, sounds good. I'll test and adapt the fix to your other themes too.

Kalyvara commented 1 month ago

Sorry for the delay, I've just sent you an invite. If you really feel like it that's cool, but it's kind of a hassle with that many variants available, so don't feel obligated. I don't even know why I bothered releasing so many variants, it's a maintenance hell and I kinda gave up lol.

I've actually been thinking about making a "CHROMA theme generator" which would allow for more streamlined edits but I'm lazy and not so much invested in the scene anymore.