The main change that this PR makes is that it implements the Local Audio Server for Yomichan (SQL version). This requires some new Android dependencies (androidx.room) in order to work. Additionally, the target SDK was changed to 33, in order for the androidx.room dependencies to work. Because the target SDK was changed, the gradle version was updated because the previous gradle version is no longer actively supported on SDK v33.
Outside of the main change, there are some other changes that are listed below.
Various README changes:
Added a Table of Contents section, to make the document easier to navigate
Separated the forvo audio step into a different section (to better match with the other optional instructions)
Separated some steps within in the original set of instruction to a Optimize Yomichan for mobile usage section, and added a section on optimizing the text input
Other small changes:
Commented out a print statement in the forvo audio section to prevent log spam
Quoted the query in canFindNotes in order to handle stuff like spaces, quotes, etc. within the query
Notes:
The fact that the user must access the app's internal data folder is not the best for user experience, and ideally, the user should be able to choose the folder. It can be left as an open issue for someone who wants to contribute to the project.
This internally adds a /localaudio/ route. I couldn't completely figure out how to add specific route handlers for arbitrary strings (i.e. /localaudio/SOURCE), so that is separated into a type parameter. It's not the ideal implementation, but I believe it will work for now. edit: the URIs are a lot saner now. See LocalAudioAPIRouting.java for the exact URIs used.
TODO:
[x] Get other sources to work + basic testing
[x] Test without DriverManager.registerDriver
[x] Update documentation (new build instructions, how to use)
[x] Update this PR message with all changes / notes (author note: don't forget build step with .so files)
The main change that this PR makes is that it implements the Local Audio Server for Yomichan (SQL version). This requires some new Android dependencies (androidx.room) in order to work. Additionally, the target SDK was changed to
33
, in order for theandroidx.room
dependencies to work. Because the target SDK was changed, the gradle version was updated because the previous gradle version is no longer actively supported on SDK v33.Outside of the main change, there are some other changes that are listed below.
Various README changes:
Optimize Yomichan for mobile usage
section, and added a section on optimizing the text inputOther small changes:
canFindNotes
in order to handle stuff like spaces, quotes, etc. within the queryNotes:
data
folder is not the best for user experience, and ideally, the user should be able to choose the folder. It can be left as an open issue for someone who wants to contribute to the project./localaudio/
route.I couldn't completely figure out how to add specific route handlers for arbitrary strings (i.e.edit: the URIs are a lot saner now. See/localaudio/SOURCE
), so that is separated into atype
parameter. It's not the ideal implementation, but I believe it will work for now.LocalAudioAPIRouting.java
for the exact URIs used.TODO:
DriverManager.registerDriver
.so
files).db
file, so users don't have to transfer 300k+ files onto their Android device