search

KamWithK / AnkiconnectAndroid

Unofficial Ankiconnect for Android (i.e. for Yomichan)
GNU General Public License v3.0
98 stars 14 forks source link

Fix get note model #42

Closed Aquafina-water-bottle closed 9 months ago

Aquafina-water-bottle commented 1 year ago

@Twinov I was playing around with updateNoteFields, and it seemed to be erroring due to having incorrect fields. This PR should fix it, and actually get the model ID of the note.

Note: Was testing the call with adb shell and curl

curl 'http://127.0.0.1:8765/' --data-raw '{"action":"updateNoteFields","version":6,"params":{"note": {"id": 1673427736656, "fields": {}}}}'
KamWithK commented 9 months ago

Hey sorry I took so long at this, I thought others had plans to do a PR review but it seems like that isn't going to happen I'm going through the PRs myself now, starting with this one and hopefully I can get them merged soon (I've had several requests to update the repo on Discord, better late than never though right)

KamWithK commented 9 months ago

FYI, I'm aware you've been awol for a few months on Discord, hoping you're still somewhat active here though Either way I'll get these PRs merged relatively soon (several people have been using this for a while so there shouldn't be any major issues)