search

KamWithK / AnkiconnectAndroid

Unofficial Ankiconnect for Android (i.e. for Yomichan)
GNU General Public License v3.0
98 stars 14 forks source link

Merge media logic #43

Closed Aquafina-water-bottle closed 9 months ago

Aquafina-water-bottle commented 1 year ago

This merges the media logic from addNote and updateNoteFields, i.e. the picture, audio, video keys.

Depends on #44 and #42

Aquafina-water-bottle commented 1 year ago

After debugging another bug where the media files in updateNoteFields do not work unless the field is also present under the base fields key, I decided to just finish this PR since this implementation actually fixed the bug by default. This PR is now required for ZXY101's mokuro branch to work.

@Twinov @sp3ctum Would appreciate a review whenever y'all have the time! Note that this PR depends on two other (smaller) PRs, so it might be worth taking a look at those first.

KamWithK commented 9 months ago

Going to merge this now as it's been extensively used for ZXY101's mokuro