Allow requests that do not specify all fields

[killergerbah]

• Some logic assumed that the client would specify a value for every field in the note type. This behavior is not present in the original AnkiConnect, and so this change is to make the behavior more similar to AnkiConnect and thus easier for AnkiConnect clients to transparently use this implementation of the API instead.
• Assumptions that a value is specified in params.note.fields for every field of the note type are removed:
  • When passing field values to the AddContentApi. An empty string is used as the default value for unspecified fields.
  • When modifying the field value map with media strings. If a field is specified for audio, that field is used even if an existing value for it doesn't exist under params.note.fields.

[killergerbah]

Hey @KamWithK, sorry for the ping, but just wanted to make sure that this PR is on your radar, just in case it might have fallen through the cracks.

[KamWithK]

Hey @KamWithK, sorry for the ping, but just wanted to make sure that this PR is on your radar, just in case it might have fallen through the cracks.

Hey mate sorry for the late reply I largely reverse engineered yomichan and looked through the docs not the code so small things like this fell through the cracks

I've given it a quick test and cards with images get added, however the audio doesn't get added

[killergerbah]

Thanks for taking the time to test it out. I didn't have issues with audio myself but I'll see if I can reproduce and fix it.

[KamWithK]

Thanks for taking the time to test it out. I didn't have issues with audio myself but I'll see if I can reproduce and fix it.

Sounds good I tested on the word 商業 btw

[killergerbah]

I was not able to reproduce the issue using Yomitan. I tried making a couple cards, one of them being 商業 and the audio field was populated, and played fine from AnkiDroid. I inspected the logic again and I couldn't there don't seem to be errors from just reading through it. Is there anything else specific to your setup that might be causing the issue?

[KamWithK]

I was not able to reproduce the issue using Yomitan. I tried making a couple cards, one of them being 商業 and the audio field was populated, and played fine from AnkiDroid. I inspected the logic again and I couldn't there don't seem to be errors from just reading through it. Is there anything else specific to your setup that might be causing the issue?

I don't think there's anything in my setup which would cause it I'll give it another go and see if it was just a temporary issue because some of my stuff was very outdated

[killergerbah]

Sweet thanks!