search

KamWithK / AnkiconnectAndroid

Unofficial Ankiconnect for Android (i.e. for Yomichan)
GNU General Public License v3.0
110 stars 14 forks source link

versioning #67

Open IzzySoft opened 1 month ago

IzzySoft commented 1 month ago

Looks like you forgot to increase the versionCode with the last release (1.14):

Binary files /web/ftp/repo/fdroid/repo/com.kamwithk.ankiconnectandroid_13.apk and /web/ftp/repo/fdroid/repo/com.kamwithk.ankiconnectandroid_1.14.apk differ

Which means that v1.13 had versionCode: 13 and v1.14 had the same – so the update won't reach anyone (as wherever v1.13 is installed, v1.14 will be considered by Android as "already there" because Android goes by versionCode).

Too late now for 1.14 (as it's already rolled out), so please do not replace the APK at the tag/release. But please ensure to remember for future releases :wink:

PS: feel free of course to create a "maintenance release" like 1.14.1 so it reaches those running v1.13.

PPS: As I see no badges in the Readme, and you might wonder where I'm reporting from: your app is listed here and can be installed and kept up-to-date with an F-Droid client of choice. Be welcome to pick a badge to link there from e.g. your Readme if you wish :smiley:

KamWithK commented 1 month ago

Hey thanks for letting me know! I always forget that and in the past before actually having it somewhere I normally just did update it on the fly aha

I will create a v1.14.1 release soon to fix the issue, and adding in a badge doesn't sound like a bad idea either 👀

IzzySoft commented 1 month ago

I should look if there's something like a "pre-tag" hook. Then I could offer that to "the forgetful". Something like: "check if versionCode(now) is bigger than versionCode(last_tag). If not, reject." Should be possible I guess… Though the docs on hooks don't mention it :cry: But something like this post-receive-hook example could work, if you want to look into it.

And thanks for considering the badge! :smiley: