search

KamalDevelopers / GodsEyeView

The next most holy operating system.
The Unlicense
49 stars 5 forks source link

Inconsistent code style #8

Closed foragerDev closed 3 years ago

foragerDev commented 3 years ago

The code is not following any particular standard, somewhere it has PascalCase, somewhere it has camelCase, some where snake_case. It has be consistent.

DevGev commented 3 years ago

The casing we use depends on where in the code the function is located and in what context the function exists. Functions within classes should be PascalCased. While stand-alone functions are snake_cased. We use different cases to specify the context of our functions, which is not something unique about GevOS as you will see this type of formatting in many other OS projects.

foragerDev commented 3 years ago

Alright, I know that, can you please tell me why here is the difference? image

DevGev commented 3 years ago

That is a mistake and should in fact not be cased like that. Some inconsistencies like this may exist in some older parts of the kernel, such as the mouse driver which rarely gets updated. The reason for this is because some of the code is derived from my older OS project. If you see anything that is clearly miss cased you can freely change it to the right casing.