Add `the_midwinter_gala` side story - Githubissues

Kamalisk / arkhamdb-json-data

JSON formatted data for the ArkhamDB deckbuilder

106 stars 149 forks source link

Add `the_midwinter_gala` side story #1420

Closed fspoettel closed 4 minutes ago

fspoettel commented 3 months ago

This adds midwinter gala.

There are a few outstanding tasks:

[x] Determine the ID space we use: tmg and following side stories would have used the 810xx-819xx ID space, which is obviously risky since it would break for side stories that have >=100 cards. Tried going to 100xxx but this breaks ArkhamDB. In coordination with @zzorba, we decided to use the unused 71xxx -> 79xxx space for now to kick the can down the road.
[x] There are a few cards where I could not determine the full card text or illustrator due to text being obscured. I marked these with comments - help welcome.
[x] I still need to proofread this myself, help is welcome though.
[x] Some encounter cards have a secondary faction assigned and use a different frame. Not sure if we should mark these somehow? FWIW we did not mark these kind of cards for War of the Outer Gods. I briefly testedfaction_code2/3 and it is not an option unfortunately.

mariokartman commented 2 weeks ago

I was looking for Midwinter Gala cards on arkhamdb and they weren't there, I was wondering how close this is to resolving?

fspoettel commented 2 weeks ago

@mariokartman currently this is awaiting a review from @drawntotheflame. I think the blocker here is that they want to play it themselves first before looking over the card text.

If you want to build decks with the new story assets, they are already added to the ArkhamCards mobile app and https://arkham.build.

drawntotheflame commented 2 weeks ago

@fspoettel where are we up to on task 4/4 in the list above? I was waiting for that before reviewing! (I'll review this weekend, but it would be good to know how we proceed with that).

fspoettel commented 2 weeks ago

@drawntotheflame I would be fine with not marking them, I think it was @zzorba that brought up the idea. I would defer the call on this to both of you.

drawntotheflame commented 2 weeks ago

@fspoettel ok, I'll proof this weekend and we can leave that untouched for now, to resolve down the line (if at all).

mariokartman commented 2 weeks ago

@fspoettel @drawntotheflame thanks for the quick replies. I was actually looking for the encounter cards - wanted to see how many Monster enemies there were - which I was able to check directly in the source here.

"to resolve down the line (if at all)." I, too, am a software developer :)

Have a good day!

fspoettel commented 2 weeks ago

Neat idea with the class tags!

Chr1Z93 commented 3 days ago

Is this PR final? Would be neat to have the story assets available for deck building!

fspoettel commented 3 days ago

Yes, I would label it as final. It is already available as is in ArkhamCards.

@drawntotheflame do you agree?