[API] /api/public/decklists/by_date/{date} does not return data

FStriewski commented 4 years ago

Although the request is formally correct (returns status code 200), the response body is empty for any given date:

Request URL
GET /api/public/decklists/by_date/2020-01-01.json?_format=json

Response Headers [Expand] 
200 OK

Response Body [Raw]
{}

Is this endpoint still supposed to be public & could it be fixed?

The API controller has not changed recently: https://github.com/Kamalisk/arkhamdb/blob/ea3fc17571f113378245aa6d22de3d8c72f4e304/src/AppBundle/Controller/ApiController.php
The route / definition has also not changed: https://github.com/Kamalisk/arkhamdb/commits/9023324caa0cc8ac42eb329d012839822aa1d0a6/src/AppBundle/Resources/config/routing/api/routing_api_public.yml

If I try the same request with thronesdb, I do get data.

zzorba commented 4 years ago

I'm fairly certain this API endpoint has never been modified to work with ArkhamDB (just a holdover from ThronesDB that was not removed).

I think some work would need to be done to update it appropriately.

FStriewski commented 4 years ago

This is a very interesting data visualization project, running some statistics with decks created over time: https://gravyanecdote.com/category/arkhamhorror/

I am pretty certain that this wouldn't have been possible without the endpoint, unless maybe some massive scraping was involved (which I'd doubt). The last data is from 2019 however.

FStriewski commented 4 years ago

I've opened a pull request for this issue. Turns out that the endpoint indeed never worked before. The project I've mentioned used some scraping software to retrieve the data.

I'd be grateful if the changes could be reviewed and merged. :slightly_smiling_face:

Kamalisk / arkhamdb

[API] /api/public/decklists/by_date/{date} does not return data #329