search

KamandPrompt / CodeManiacs

IIT Mandi Online Judge
MIT License
23 stars 58 forks source link

Displaying value fields in edit profile #158

Closed PiyushDhamane closed 3 years ago

PiyushDhamane commented 3 years ago

155

Previously the email and name fields were rendered blank in profile update. Now the user's current profile fields are correctly displayed.

image

Signior-X commented 3 years ago

@Piyush3436 see the commits, it has commits from your other PR. This should not be the case. So, yes you did it on another branch, but while working on another issue, you should create the new branch starting with the current master of this repo i.e the upstream. The head of the commits should not be started from some other branch.

So,

  1. You should close this PR.
  2. Checkout to your master branch
  3. Pull the lastest code to master branch from here
  4. Now, create a new branch from that head and work on the issue.

The thing is the commits should only be for the issue you are working on the PR. You can see that your this branch and current master has actually diverged.

Signior-X commented 3 years ago

This one is messed up, so working on the other PR made