KamandPrompt / CodeManiacs

IIT Mandi Online Judge

MIT License

23 stars 58 forks source link

fixed #167 depraciation warnings #168

Closed Creatoon closed 3 years ago

Creatoon commented 3 years ago

What's this PR do? (related issue if exists)

Previously I solved this issue but accidentally changed the indentation of the codebase, this PR includes a fix of Depreciation warnings appearing in the console, further details in the screenshot below.

issue is solved.

bugFix

Creatoon commented 3 years ago

this pr resolved issue #167

dheeraj135 commented 3 years ago

Changes looks ok to me. @Signior-X will review and merge this PR.

Signior-X commented 3 years ago

@pranshukharkwal do we need to remove the depreciation warning.... what say? Changes seem good to me.

pranshukharkwal commented 3 years ago

@Signior-X Yes I think it is good to get rid to such warnings. You can merge the PR if the code changes are correct.

Signior-X commented 3 years ago

Yes the code is exact to the point @pranshukharkwal merging it. Great work done @Creatoon

Hope to see more contribution from your side in future.