search

KamandPrompt / SAC-Portal

SAC Portal for IIT Mandi
2 stars 17 forks source link

Sac #25

Open yamini27 opened 4 years ago

yamini27 commented 4 years ago

I created endpoint for Register and Login page. There is one issue that it uses 'register.html' for register() function which has not been created yet. And username is kept of length of 6 characters considering our Roll no. b1XXXX .Email can be any email for now. @Milind712000 please review this issue.

yamini27 commented 4 years ago

Sir, the Login and register new user pull request (https://github.com/KamandPrompt/SAC-Portal/pull/25/commits/8d885b6ce62d048e496b43180a39a75702fc3d87) was made by mistake. So, please ignore it and review only Register and Login new user.

yamini27 commented 4 years ago

Sir, for the issue #13 , I have made changes in app.py as was asked in Login and Regiter new user ( b3b89bf ). Login and Register ( 52c2819 ) includes session admin status and email which I forgot earlier. RegisterForm is included in Forms ( c0e6071 ). I have made a new template named dashboard such that the user will be directed to dashboard after logging-in. Since the route of Home is '/', it will be shown before login page.Hence, I have made changes accordingly. Sir, Please review these commits and suggest necessary changes.

yamini27 commented 4 years ago

Sir, I have made changes as asked. Please review the PR for the issue #13 and suggest further changes.

karanankit01 commented 4 years ago

The current patch of this PR is working fine, you just need a few minor changes

yamini27 commented 4 years ago

Sir, I have made changes as asked in commit 3365401. I haven't added any specific errors for the possible errors in RegisterForm and have relied on form.errors by default for all form errors. Please review this PR for #13 and suggest further changes.

yamini27 commented 4 years ago

Sir, I have made necessary changes in commit da1973a for the issue #13 . It works perfect now. Please review this commit and suggest any further changes.

yamini27 commented 4 years ago

Sir, made the changes for the issue #13 . Please review it and suggest any further changes.

yamini27 commented 4 years ago

Sir, I have made commit for the issue #13 in b5ea0ef. Now, it's working fine. Please review it and suggest further changes.

yamini27 commented 4 years ago

Sir, I've made changes for the issue #13 . Please review the commit and suggest any further changes.

yamini27 commented 4 years ago

Sir, I have made changes and squashed all commits in 5dd97d8 for the issue #13 . Please review it and suggest any further changes.

yamini27 commented 4 years ago

Sir, new commit bd363bb for the issue#13 has the asked changes. Please review it and suggest any further changes.

yamini27 commented 4 years ago

Sir, I made asked changes for the issue#13 in commit d7675e5. Please review it and suggest any further changes.