search

KamandPrompt / kamandprompt.github.io

Kamandprompt Open Source Website
https://pc.iitmandi.co.in
MIT License
10 stars 42 forks source link

Add ability to create gsoc page from data.yaml file #111

Open pranshukharkwal opened 4 years ago

pranshukharkwal commented 4 years ago

Solves #110 @vsvipul

pranshukharkwal commented 4 years ago

@abhigyank I would rather replace c4 with row4 because it denotes the number of rows with four elements

abhigyank commented 4 years ago

Sounds good. I couldn't understand what c4 was, so I guessed it would be column4. It would therefore definitely help to have well worded variable names. If it denotes "number of rows with four elements" why not name the variable as four_elements_rows or rows_with_four_elements? Such naming would be more clearer.

pranshukharkwal commented 4 years ago

@abhigyank I have changed variable names and added comments. Let me know if the code is understandable now?

abhigyank commented 4 years ago

Much better. Leaving it to @vsvipul to review :)

kpbot commented 4 years ago

Heads up @pranshukharkwal, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.