KamandPrompt / kamandprompt.github.io

Kamandprompt Open Source Website
https://pc.iitmandi.co.in
MIT License
10 stars 42 forks source link

improved project_contributors page #118

Closed LalitNM closed 3 years ago

LalitNM commented 3 years ago

I tried to fix #81. Please let me know if it can be improved further. Changes:

LalitNM commented 3 years ago

Thanks @kpbot, I ammended my last commit.

LalitNM commented 3 years ago

@kartik1000 can you have a look on this.

kartik1000 commented 3 years ago

Yeah sure!

kartik1000 commented 3 years ago

@LalitNM The changes look good!. The previous UI was not in sync with the rest of the pages. Hey there is an issue. Can you update Shrikha's and HitRam's picture? Screenshot 2020-10-05 at 4 23 45 PM

LalitNM commented 3 years ago

@kartik1000 We use a web scraping here using github's api, the picture of a contributor is same as the profile picture of that contributor on github. So, in order to update picture of any contributor they have to upload another picture of themselves on github. Do you want me to manually add pictures on this page?

kartik1000 commented 3 years ago

Yeah if you can overwrite the same for these two. Please do so.

LalitNM commented 3 years ago

I updated the PR @kartik1000. A screenshot: image

abhigyank commented 3 years ago

Yeah if you can overwrite the same for these two. Please do so.

@kartik1000 Wouldn't this require hard-coding of code? I don't suppose that's a good practice, what do you think?

kartik1000 commented 3 years ago

@abhigyank Well, I am sure many of our juniors won't know Hitesh sir and it would be great if they can see him :) Although, this is hard coding but since we are over-writing, I don't think it will cause an issue within the main algorithm of web scraping.

abhigyank commented 3 years ago

@kartik1000 Ping Hitesh to put a DP on GitHub 😁

@HitRam Please put a DP on GitHub 😛

LalitNM commented 3 years ago

@kartik1000 I removed unnecessary code which was used to override github api, have a look.

vsvipul commented 3 years ago

@kartik1000

kartik1000 commented 3 years ago

@LalitNM Good Work. Looks good to me. Merging :)