Closed LalitNM closed 3 years ago
Thanks @kpbot, I ammended my last commit.
@kartik1000 can you have a look on this.
Yeah sure!
@LalitNM The changes look good!. The previous UI was not in sync with the rest of the pages. Hey there is an issue. Can you update Shrikha's and HitRam's picture?
@kartik1000 We use a web scraping here using github's api, the picture of a contributor is same as the profile picture of that contributor on github. So, in order to update picture of any contributor they have to upload another picture of themselves on github. Do you want me to manually add pictures on this page?
Yeah if you can overwrite the same for these two. Please do so.
I updated the PR @kartik1000. A screenshot:
Yeah if you can overwrite the same for these two. Please do so.
@kartik1000 Wouldn't this require hard-coding of code? I don't suppose that's a good practice, what do you think?
@abhigyank Well, I am sure many of our juniors won't know Hitesh sir and it would be great if they can see him :) Although, this is hard coding but since we are over-writing, I don't think it will cause an issue within the main algorithm of web scraping.
@kartik1000 Ping Hitesh to put a DP on GitHub 😁
@HitRam Please put a DP on GitHub 😛
@kartik1000 I removed unnecessary code which was used to override github api, have a look.
@kartik1000
@LalitNM Good Work. Looks good to me. Merging :)
I tried to fix #81. Please let me know if it can be improved further. Changes: