Closed divyashk closed 4 years ago
@vsvipul Is this needed? :) Hey @divyashk If you wish to make a small change, there is a bug on the team page that the sntc check website page button is not highlighted on toggling unlike other buttons please fix this.
@kartik1000 On it bro👍
@kartik1000 Kindly review it when free.
These sections are completely responsive and the code is full of comments explaining it's mechanism.
Instead of showing 9+6, I think we should show 9 Students and 6 Mentors. @divyashk
Can we have the first one open by default?
Can we have the first one open by default?
yeah sure, anything else?@abhigyank
Instead of showing 9+6, I think we should show 9 Students and 6 Mentors. @divyashk
@vsvipul if that's what you want.
@vsvipul @abhigyank
Looks good, I'll leave it to @kartik1000 to review and merge.
@divyashk, Always create a new branch in your forked repo before a new pull request. Otherwise, you will end up making changes in master in your forked repo which may not be merged upstream. You can revert it but try to create a new branch right from start. I am reviewing the changes.
@divyashk, Always create a new branch in your forked repo before a new pull request. Otherwise, you will end up making changes in master in your forked repo which may not be merged upstream. You can revert it but try to create a new branch right from start. I am reviewing the changes.
@kartik1000 Will do that from now on.
@divyashk Can you adjust the layout as it was originally? I don't know if this was intentional or as a result of adding dropdowns but change it to the original one. The dropdown idea is a really good one and it makes the page more awesome. Great Work. Just make the layout changes and then we can merge
This is the original Layout.
This is the resized Layout. It is making the boxes more crowded.
@kartik1000 It is fixed now.
@divyashk The changes look good. Ready to merge :)
@divyashk, There is some issue. See the GSoC page, The result is not what we see locally. I think you might have missed out some dependency which is present locally, but not on the server.
This is what we were getting locally, This is what we are getting now, is it the same on your system? Try to open the site and check.
It is somehow showing as expected on safari but not on chrome. Working good on chrome mobile as well. Please check @divyashk
@kartik1000 try doing a hard reload and clearing cache.
@kartik1000 Even I got the same first, but ctrl+shift+R worked.
Ok, now it is working fine for me as well. Every time. Good Job 👍 . I was not aware media queries would require a hard reload :/
Changed the font-size of the button.
Before
After