search

Kamatera / packer-plugin-kamatera

Packer plugin for Kamatera Cloud Builder
Mozilla Public License 2.0
2 stars 3 forks source link

Add automated acceptance tests #16

Closed OriHoch closed 3 years ago

OriHoch commented 3 years ago

e.g. https://github.com/hashicorp/packer-plugin-scaffolding/blob/main/.github/workflows/test-plugin-example.yml

Check Hashicorp guidelines to make sure we will pass their review - https://www.packer.io/docs/plugins/packer-integration-program#3-dev-test

imcvampire commented 3 years ago

This action - https://github.com/hashicorp/packer-plugin-scaffolding/blob/main/.github/workflows/test-plugin-example.yml - is triggered by hand because it needs goreleaser finishes first.

OriHoch commented 3 years ago

please have the acceptance test run automatically on every push to main branch

imcvampire commented 3 years ago

Acceptance test means the workflow above or just unit tests?

OriHoch commented 3 years ago

the workflow above

imcvampire commented 3 years ago

But it won't work until you create a tag and let goreleaser finishes its job.

You can check other packers. All of them don't run it automatically https://github.com/hashicorp/packer-plugin-googlecompute/blob/main/.github/workflows/test-plugin-example.yml

OriHoch commented 3 years ago

for the packer-plugin-googlecompute they seem to run tests in circleci - https://github.com/hashicorp/packer-plugin-googlecompute/blob/main/.circleci/config.yml

Regarding our acceptance test - it should compile a binary for linux and then run the acceptance test on it (create an image)

imcvampire commented 3 years ago

@OriHoch The acceptance test runs automatically now after goreleaser finishes

OriHoch commented 3 years ago

please have the test run on every push to main branch - we should run the test before releasing