search

Kamatera / packer-plugin-kamatera

Packer plugin for Kamatera Cloud Builder
Mozilla Public License 2.0
2 stars 3 forks source link

Run example/test on PR #25

Closed imcvampire closed 3 years ago

imcvampire commented 3 years ago

Close https://github.com/Kamatera/packer-plugin-kamatera/issues/16

imcvampire commented 3 years ago

thanks, looks good

regarding triggering it on pull requests - this could be a security risk, because the kamatera secrets will be available, so someone could open a pull request "steals" those secrets or uses them maliciously, so I think it's better not to allow that or maybe if possible limit it in some way, I'm not too familiar with how it works

I think the only way is running on the master branch. What do you think?

OriHoch commented 3 years ago

yes, running only on pushes to main branch is safe

imcvampire commented 3 years ago

@OriHoch Please review again!