search

Kami / python-yubico-client

Python library for validating Yubico Yubikey One Time Passwords (OTPs) based on the validation protocol version 2.0.
https://yubico-client.readthedocs.org/en/latest/
Other
83 stars 19 forks source link

verify_cert not triggering the HTTPS CA check correctly (or skipping it) #5

Closed mediamanrit closed 11 years ago

mediamanrit commented 12 years ago

In the Notes section on the project page (https://github.com/Kami/python-yubico-client), it says you have to specify “verifiy_cert = True” if you want to verify the HTTPS connection, and change CA_CERTS to point the path of a CA file. I left all the default values (including CA_CERTS=’’), and I got an exception: “Exception: If you want to validate server certificate, you need to set CA_CERTS variable in the httplib_ssl.py file pointing to a file which contains a list of trusted CA certificates”. I looked at yubico.py, and that exception is raised even if verify_cert=False. I THINK the if line should be changed to “if use_https and httplib_ssl and httplib_ssl.CA_CERTS == '' and verify_cert: “

Kami commented 11 years ago

This should be fixed in the v1.6.0 version which has been released today - http://pypi.python.org/pypi/yubico/1.6.0.

Please let me know if you are still experiencing those problems with a new version.