KamiKillertO / vscode-colorize

A vscode extension to help visualize css colors in files
Apache License 2.0
268 stars 37 forks source link

Add support for the following HSL syntax #900

Open spacecat opened 7 months ago

spacecat commented 7 months ago

Add support for the following HSL syntax:

hsl(360 50% 50%) hsl(360deg 50% 50%) hsl(360deg, 50%, 50%)

Note: The legacy hsla() syntax is an alias for hsl(), accepting the same parameters and behaving in the same way.

Source: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/hsl

So hsla regex should be removed IMO.

spacecat commented 7 months ago

@KamiKillertO you think you have some time to check this PR? 🙂

KamiKillertO commented 6 months ago

@spacecat Can you add some tests?

spacecat commented 2 months ago

Sorry, life caught up with me.. been and am very busy so won't be able to create tests in a while if ever... :( I hope someone else can find some time to do it or create an entirely new PR.