search

Kampfkarren / full-moon

A lossless Lua 5.1 parser
Mozilla Public License 2.0
365 stars 47 forks source link

Rename based on lpg's suggestions #157

Open Kampfkarren opened 3 years ago

Kampfkarren commented 3 years ago

names I would pick:

  • TokenType becomes Token
  • TokenKind becomes TokenType
  • Token becomes SpannedToken
  • TokenReference becomes... SpannedTokenWithTrivia?

Based on @tomprince's work, TokenReference will be WithTrivia<Token>, and potentially Token to Spanned<Token>.

tomprince commented 3 years ago

I think TokenKind is a better name than TokenType. It lines up better with all the ErrorKind enums, which serve a similar purpose.

Kampfkarren commented 3 years ago

Yeah, I agree, I'm just copying the old message.