search

Kampfkarren / roblox-install

Get the install directory of Roblox in Rust
Mozilla Public License 2.0
8 stars 4 forks source link

MacOS support #5

Closed jeparlefrancais closed 5 years ago

jeparlefrancais commented 5 years ago

These changes does not include the plugins_path method yet. I have it ready on another branch, so if the PR #3 merges before I'll merge it on this branch.

I got one question: should we keep the root field? There is kind of a significant difference between Mac and windows so I am not sure how usable it is. Let me know if you want to remove it!

Closes #2

Kampfkarren commented 5 years ago

LGTM (assuming you tested this, I don't have a Mac unfortunately) aside from the alphabetical order thing.

MisterUncloaked commented 5 years ago

I tested this on a mac and it works well.

Kampfkarren commented 5 years ago

Thanks!