Fix compilation issue #44 introduced in v2.2.0

Kanaka-io / play-monadic-actions

A simple scala DSL to allow clean and monadic style for Play! Actions

Other

128 stars 29 forks source link

Fix compilation issue #44 introduced in v2.2.0 #45

Open marko-asplund opened 4 years ago

marko-asplund commented 4 years ago

Fix issue #44 by reverting comming 0d81d07dc779716627ed2092ec61a417bbfd42ce

ping @vil1

coveralls commented 4 years ago

Coverage decreased (-0.1%) to 96.591% when pulling 317645572e24a6de32c688e0b50d638982a8fdb8 on marko-asplund:fix-compilation-issue-44 into 3b3cc3cde458e37b4868d5d8bf5b877236853011 on Kanaka-io:master.

vil1 commented 4 years ago

I won't have time to look at this before this weekend I'm afraid, but I promise I'll do.

marko-asplund commented 4 years ago

I'm reluctant to remove this method completely as it may be used by some client projects.

One could argue that the breaking change was 0d81d07dc779716627ed2092ec61a417bbfd42ce and that this PR only reverts that 😬 .

I'd prefer to explore a non-breaking solution to this problem

🤔 I'm not sure how fBooleanToStepOps can be left there without breaking code using a pre 2.2.0 version. Any ideas?