search

Kanaksinh / gtalksms

Automatically exported from code.google.com/p/gtalksms
0 stars 0 forks source link

Set MUC Password only as fallback #56

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Did some testing with my muc server which handles the roomconfig_roomowners 
form just fine. So I though it would be nice to have an membersonly room when 
this setting works and as fallback a password protected room.

Here is the patch. Seems to work nice.

Original issue reported on code.google.com by fschm...@gmail.com on 20 Jan 2011 at 6:59

Attachments:

GoogleCodeExporter commented 8 years ago 
The addition of "return null" in XmppManager.java after Log.e(Tools.LOG_TAG, 
"createRoom: room = " + room, ex);  is misleading/wrong, as this catch block 
catches the following exception (at least on jwchat.org): 
E/gtalksms(20127): Error on creating room: room = xx (00491xx)
E/gtalksms(20127): Creation failed - Missing acknowledge of room creation.: 
E/gtalksms(20127):   at 
org.jivesoftware.smackx.muc.MultiUserChat.create(MultiUserChat.java:343)
E/gtalksms(20127):   at 
com.googlecode.gtalksms.XmppManager.createRoom(XmppManager.java:422)

but the room is still created.

Original comment by fschm...@gmail.com on 21 Jan 2011 at 11:06

GoogleCodeExporter commented 8 years ago

Original comment by Florent....@gmail.com on 21 Jan 2011 at 7:17

GoogleCodeExporter commented 8 years ago

Original comment by Florent....@gmail.com on 22 Jan 2011 at 4:12

GoogleCodeExporter commented 8 years ago 
Fixed in 1.7.3

Original comment by Florent....@gmail.com on 22 Jan 2011 at 8:07

GoogleCodeExporter commented 8 years ago

Original comment by fschm...@gmail.com on 25 Aug 2011 at 7:51