search

Kanaries / Rath

Next generation of automated data exploratory analysis and visualization platform.
https://kanaries.net
GNU Affero General Public License v3.0
4.29k stars 335 forks source link

delete kruskal with limit size, use largest size to limit it(uncontrolled group ... #19

Closed todo[bot] closed 4 years ago

todo[bot] commented 4 years ago

https://github.com/Kanaries/Rath/blob/24f260934377bb06c7c0f609eb11cf07d3e6725a/packages/visual-insights/src/ml/cluster/kruskal.ts#L84-L87

This issue was generated by todo based on a todo comment in 24f260934377bb06c7c0f609eb11cf07d3e6725a when #17 was merged. cc @Kanaries.
ObservedObserver commented 4 years ago

It seems not logical to limit a group size if members in it are highly correlated with each other. Now, we are using a threshold of correlation and group number.

The original reason for this issue is seeking a solution to limit the number of the field in one visualization. However, a large group of fields can be made into a dashboard or story instead of a single vis.