search

Kanaries / graphic-walker

An open source alternative to Tableau. Embeddable visual analytic
https://docs.kanaries.net/graphic-walker
Apache License 2.0
2.53k stars 135 forks source link

[BUG]Offset appears while dragging 'field' pill #24

Closed Asm-Def closed 1 year ago

Asm-Def commented 1 year ago

I recently embedded Graphic Walker in Jupyter Notebook (https://github.com/Kanaries/pygwalker).

Then I found Top Tabbars and Left Sidebars always cause a strange offset while dragging pills from the field list, see the GIF

Feb-20-2023 12-53-27

AntoineYANG commented 1 year ago

I consider that it may be relative to this issue in react-beautiful-dnd https://github.com/atlassian/react-beautiful-dnd/issues/1881

ObservedObserver commented 1 year ago

fixed in https://github.com/Kanaries/graphic-walker/commit/77cc0e6735541d9d9196665c8076a2251e34565c.

If you have a fixed/absolute/transformed container, add a param fixContainer to GraphicWalker

<GraphicWalker fixContainer={true} />

But there still exists some edge cases.

ObservedObserver commented 1 year ago

It seems fixes another situation (for a fixed or transformed container) not the one in JuypterLab.

ObservedObserver commented 1 year ago

fixed