search

Kanaries / pygwalker

PyGWalker: Turn your pandas dataframe into an interactive UI for visual analysis
https://kanaries.net/pygwalker
Apache License 2.0
13.45k stars 707 forks source link

[Feat] Detect white-dark theme and use appropriate theme #20

Closed hyiltiz closed 1 year ago

hyiltiz commented 1 year ago

Currently, using pyg.walk(df) on a Jupyter Notebook with a dark theme renders a white widget, where most text are so low contrast that they are effectively invisible.

ObservedObserver commented 1 year ago

graphic-walker has supported media themes now. https://github.com/Kanaries/graphic-walker/pull/31

we are upgrading pygwalker to the latest graphic-walker.

gw-dark-scatter

hyiltiz commented 1 year ago

Does that has any impact on the call site (user API), or it is just an upgrade to the pygwalker's internal calls to graphic-walker?

Asm-Def commented 1 year ago

See pr #48 .

It's just an upgrade of graphic-walker itself, but I'd prefer to export an option for user API in the future.

ObservedObserver commented 1 year ago

Use pygwalker with auto-theme (based on your device) in the latest version. pip install --upgrade "pygwalker>=0.1.4.6"