search

Kane610 / aiounifi

Asynchronous library to communicate with Unifi Controller
MIT License
60 stars 53 forks source link

EVT_DM_Connected events #682

Closed daxy01 closed 5 months ago

daxy01 commented 5 months ago

I've noticed my Home-Assistant complained that event EVT_DM_Upgraded was unsupported. The following 2 messages are shown: 2024-06-17 18:07:42.438 WARNING (MainThread) [aiounifi.models.event] Unsupported event key EVT_DM_Upgraded 2024-06-17 18:07:42.438 WARNING (MainThread) [aiounifi.models.event] Unsupported event {'version_from': '4.0.5.16380', 'version_to': '4.0.6.16512', 'key': 'EVT_DM_Upgraded', 'dm': '9c:05:d6:xx:xx:xx', 'gw': '9c:05:d6:xx:xx:xx', 'dm_name': 'UCG Ultra', 'dm_model': 'UDRULT', 'dm_displayName': 'UCG Ultra', 'gw_displayName': 'UCG Ultra', 'subsystem': 'lan', 'is_negative': False, 'site_id': '666be93249717f04xxyyzzxx', 'time': 1718640458247, 'datetime': '2024-06-17T16:07:38Z', 'msg': '9c:05:d6:xx:xx:xx was upgraded from "4.0.5.16380" to "4.0.6.16512"', '_id': '66705f4a223ce91exxyyzzxx'}

Judging by https://github.com/Kane610/aiounifi/pull/402, this should be the fix: file: aiounifi/models/event.py 41 + DREAM_MACHINE_UPGRADED = "EVT_DM_Upgraded"

Kane610 commented 5 months ago

Judging by #402, this should be the fix: file: aiounifi/models/event.py 41 + DREAM_MACHINE_UPGRADED = "EVT_DM_Upgraded"

Why didn't you put up a PR then? :)

daxy01 commented 5 months ago

lol, figuring out how to fork, fix and submit a PR for just this single line would have taken me all afternoon. I admit, I'm lazy (though I did my best to make this issue as complete as possible) 😀. Thanks for your help!!!

Kane610 commented 5 months ago

lol, figuring out how to fork, fix and submit a PR for just this single line would have taken me all afternoon. I admit, I'm lazy (though I did my best to make this issue as complete as possible) 😀. Thanks for your help!!!

You could have done it from the GitHub web interface ;). Your welcome