search

Kang-Quan / pe

0 stars 0 forks source link

Valid website is unable to be added in the add command #3

Open Kang-Quan opened 2 years ago

Kang-Quan commented 2 years ago

tinyurl.com/catcher-web is a valid website but is unable to be put in the app.

Steps to replicate: Step 1: add n/Google100 ph/98765432 e/johnd@example.com r/Y2 summer break p/Backend Intern pr/applied d/12-12-2022 web/tinyurl.com/catcher-web t/high t/java

image.png

The constrain is too tight so it is considered a featureflaw

nus-pe-script commented 1 year ago

Team's Response

Website must start with https or http as clearly stated in the User Guide and in the error message. From a user perspective, they are more likely to copy the website URL into the command box from the webpage as compared to typing the whole URL as some website URL can be quite long. Copying of the whole URL would include the https or http protocol.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: From your user guide, this application is made with CLI users in mind and specifically computer science students. Some students may be well aware of the company's career page and is able to accurately type it out without reference.

For convenience sake, modern browsers will not require you to include http and https as it will be auto included. Since it is CLI based and most students are using modern browsers, most of the users will intuitively exclude https/http protocol when typing. For example, will a user type https://facebook.com or just facebook.com. This might be a case of overzealous input validation. Since accepting links like facebook.com, careers.shopee.sg or github.com will not hinder operation of software. While rejecting them may annoy or slow down the speed of using the application.

image.png

It is a flaw that occasionally affects user which causes some inconvenience but they can continue to use the product hence given a medium severity tag.

image.png