search

KangChangKi / solrmeter

Automatically exported from code.google.com/p/solrmeter
0 stars 0 forks source link

Not obvious that you need echoParams=all! #84

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.Use an external file that doesn't have echoParams=all
2.Do a query, only the first one is run, and no results.
3.If you look at solrmeter.log you will see the error.

What is the expected output? What do you see instead?

If I hack my external queries file to have echoParams=all, then it works.

I think you need better error handling around line 
http://code.google.com/p/solrmeter/source/browse/trunk/sources/solrmeter/src/mai
n/java/com/plugtree/solrmeter/model/statistic/QueryLogStatistic.java#103  which 
is where I am seeing the error.

Original issue reported on code.google.com by ep...@opensourceconnections.com on 3 Aug 2011 at 9:50

GoogleCodeExporter commented 9 years ago

Original comment by tflo...@gmail.com on 4 Aug 2011 at 9:38

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r251.

Original comment by juan.gra...@gmail.com on 5 Aug 2011 at 3:04

GoogleCodeExporter commented 9 years ago

Original comment by juan.gra...@gmail.com on 5 Aug 2011 at 3:10

GoogleCodeExporter commented 9 years ago 
So, looking at r251, it doesn't seem like it actually adds the echoParams if it 
is missing.  You added to the example of course, but should SolrMeter add it if 
I haven't???/

Original comment by ep...@opensourceconnections.com on 5 Aug 2011 at 3:10

GoogleCodeExporter commented 9 years ago 
Hi,

In my opinion, echoParams=all shouldn't be forced (at least by default). 
Currently the only drawback of using echoParams=none is that the "q" and "fq" 
columns of the "Query Statistics" console will be empty. If you want to show 
all the data, then you'll have to edit your queries file or change your request 
handler configuration. Anyway, I'll create an issue to add a "Force 
echoParams=all" switch to the configuration dialog.

Original comment by juan.gra...@gmail.com on 5 Aug 2011 at 3:36

GoogleCodeExporter commented 9 years ago

Original comment by juan.gra...@gmail.com on 5 Aug 2011 at 3:41

GoogleCodeExporter commented 9 years ago 
cool.   One of the things I like about SolrMeter is it makes it easy for 
novices to Solr to do some pretty sophisticated stuff.  So I vote for sane 
defaults that make it easy to use!

Original comment by ep...@opensourceconnections.com on 5 Aug 2011 at 4:40

GoogleCodeExporter commented 9 years ago

Original comment by tflo...@gmail.com on 9 Oct 2012 at 10:48