KangoExtensions / kango

Kango framework issue tracker
74 stars 7 forks source link

Safari BEFORE_NAVIGATE doesn't have KangoBrowserTab #166

Open AlexLongToptal opened 8 years ago

AlexLongToptal commented 8 years ago

The event object returned to the BEFORE_NAVIGATE listener in Safari only has a url property. It doesn't have a target property pointing to the BrowserTab object as the documentation says:

BEFORE_NAVIGATE // Fired when request starts event = { KangoBrowserTab target, string url }

Without target, there's no way to reference the tab that actually triggered the event. You can assume that the event was triggered by the current tab and just do kango.browser.tabs.getCurrent but that assumption is not necessarily always correct.