Kanika637 / amazon-clone

Clone of Amazon Website
MIT License
89 stars 100 forks source link

Sign in form can't take mobile numbers as login username #123

Closed mecskyverse closed 1 year ago

mecskyverse commented 1 year ago

Describe the bug

In Login Form while creating a new account there is a option of entering either Mobile Number or email

image

But we can't enter the mobile number as a login credential because it only accepts email id as a credential image

Expected behaviour

Option 1:-

Either We can simply write to enter Email id in login form so that it only accept for email id.

Option 2:-

We can manipulate the code such that it can accept both number as well as email id for login Credential.

Screenshots

No response

Additional context

No response

mecskyverse commented 1 year ago

Hey @Kanika637 can you assign this issue to me as a hactoberfest contribution.

Kanika637 commented 1 year ago

Thanks for opening the issue @mecskyverse, Go ahead🚀

mecskyverse commented 1 year ago

Hey @Kanika637 I was going through the feature to add phone number authentication but as this project's authentication is supported by firebase and when I researched about it I get to know I need to login in firebase account for which I need to login in google account of yours and which is not appropriate. To add phone number authentication in this project. I wanted your help to know if there is any other way or should I remove sentence of entering phone number something like this. image

Kanika637 commented 1 year ago

Hey, @mecskyverse you can consider removing the mobile number field and go ahead with the email.