Kanika637 / amazon-clone

Clone of Amazon Website

MIT License

89 stars 100 forks source link

#149 side nav closing #150

Closed mecskyverse closed 1 year ago

mecskyverse commented 1 year ago

Description

Fixes: #149 Side bar Head is overlapping with sidebar body hence it is causing problem to close the Side Navbar.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK:

Before After

mecskyverse commented 1 year ago

Hey! @Kanika637 can you review this one.

mecskyverse commented 1 year ago

It's my first time encountering a change request and I have added two commits as per your suggestion. Is it good to go or should I add something else?

Kanika637 commented 1 year ago

It's my first time encountering a change request and I have added two commits as per your suggestion. Is it good to go or should I add something else?

Yes you did it right👍