Kanika637 / amazon-clone

Clone of Amazon Website
MIT License
89 stars 100 forks source link

making a layout component for headers and footer #172

Open ghost opened 1 year ago

ghost commented 1 year ago

Describe the bug

hi! @Kanika637 😁 we could make the App.js more clean to see

Expected behaviour

Layout =({children})=>{
     <Header/>
         {children}
     <Footer/>
}
main=()=>{
  return <Layout >
  Cart component 
   </Layout>
}
main=()=>{
  return <Layout >
  Product component 
   </Layout>
}

Screenshots

No response

Additional context

No response

mud1tx commented 1 year ago

I can work on it if the issue is still active.

mud1tx commented 1 year ago

I am trying to install the npm package but it is not running and showing some errors. Screenshot (355)

I think that some packages are deprecated.

mud1tx commented 1 year ago

I can fix the issue without running the project, just have to add Layout component?

Kanika637 commented 1 year ago

I am trying to install the npm package but it is not running and showing some errors. Screenshot (355)

I think that some packages are deprecated.

Hey, try the command with -- force or --legacy-peer-deps as suggested. I think that would work.

ThienBNguyen commented 1 year ago

Hi Can I work in this issue?

mominrazashahid commented 4 weeks ago

@Kanika637 i open PR to fix this issue can you please review my PR i want to work on this project. Thank you