getUUID - properly handle non-existent users

Kanin / PyPixel

A Python Wrapper for The Hypixel API

MIT License

10 stars 2 forks source link

getUUID - properly handle non-existent users #13

Closed HiddenKitten closed 6 years ago

HiddenKitten commented 6 years ago

seems like this could be made a bit better using requests, instead of direct calls to urlopen..

this solves #12 although, I'm sure this could be done much more elegantly... please, before merging, do make sure that this doesn't break any other functionality, or is broken on python 2, as I've only tested python 3 and only using the code within #12, but my changes should support python 2.7 and earlier as well.

destruc7i0n commented 6 years ago

I'm awfully sorry for getting to you months late, but I just looked over everything and it seems fine to me! I'll merge this.