search

Kanin / PyPixel

A Python Wrapper for The Hypixel API
MIT License
10 stars 2 forks source link

Added Skyblock Functions for Profile and Auction House #15

Open fivepoint-0 opened 4 years ago

fivepoint-0 commented 4 years ago

I will be looking at this more. I think you got something pretty cool here! I want to see if I can help build the library if possible. Cheers! I didn't add definitions/docs to the code but I'll do it soon.

destruc7i0n commented 4 years ago

I haven’t worked with the API since around 2016, so I can’t really comment too much on the functions themselves. A few thoughts though:

Why does setMainSkyblockProfile exist? I don’t see it being used in the lib anywhere. I notice that getSkyblockAuctions uses pages, can the user specify which page they want to go to in the parameters? Also, it would be nice to have the inline docs as well.

fivepoint-0 commented 4 years ago

I haven’t worked with the API since around 2016, so I can’t really comment too much on the functions themselves. A few thoughts though:

Why does setMainSkyblockProfile exist? I don’t see it being used in the lib anywhere. I notice that getSkyblockAuctions uses pages, can the user specify which page they want to go to in the parameters? Also, it would be nice to have the inline docs as well.

setMainSkyblockProfile was just a function I implemented because grabbing your Skyblock profile returned more than one result. I will look at the docs, refactor the code, add internal docs, and resubmit. Thanks!

Also, they cannot choose the page yet but I will parameter-ize that!