search

Kanin / PyPixel

A Python Wrapper for The Hypixel API
MIT License
10 stars 2 forks source link

Tweaked it to work with Python 2 and 3 #7

Closed ttofis closed 8 years ago

ttofis commented 8 years ago

And fixed the annoying fake commit at the end!

ttofis commented 8 years ago

Removed one if statement. Now, it should run a bit faster. Reason for two commits: Weird conflict issue. No idea why.

yrsegal commented 8 years ago

AAAAAAAAA why are you importing on runtime that's the opposite of what I said to do

ttofis commented 8 years ago

Is it now like you said me to do?

yrsegal commented 8 years ago

200e95f9d7adb4c8886e188eac4d1ee40a50a971

ttofis commented 8 years ago

Oh. I didn't know this method. I am sorry.

ttofis commented 8 years ago

At least you could tell me how do you like it and just merge. Even squash the commits so it shows as one. But I don't know... It seems that you work on the project and it isn't dead for 6 months. At least, pypixel is getting updated. Which is something on it's own.

yrsegal commented 8 years ago

The thing is that squashing the commits you have would have still required a fixit commit. Doing a single commit made more sense.

This is d70's pet project, not mine. I just made it better. If you want to complain about a dead API, do it to him. On Wed, May 4, 2016 at 3:09 PM ELChris414 notifications@github.com wrote:

At least you could tell me how do you like it and just merge. Even squash the commits so it shows as one. But I don't know... It seems that you work on the project and it isn't dead for 6 months. At least, pypixel is getting updated. Which is something on it's own.

— You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub https://github.com/destruc7i0n/PyPixel/pull/7#issuecomment-216969618

ttofis commented 8 years ago

I didn't complaint that the api is dead. Let's just end this conversation here. It doesn't matter. The thing that matters is that with work by you and me we made the api better. That's what matters. The community working on making something better.

ttofis commented 8 years ago

And also I am sorry if I made it look that I was angry. Totally not.