search

KanjiVG / kanjivg

Kanji vector graphics
http://kanjivg.tagaini.net
Other
1.05k stars 180 forks source link

Convert make-index script to Python #430

Closed nix6839 closed 7 months ago

nix6839 commented 7 months ago

The repository's scripts now only include .sh and .py, and there's no longer a need to install additional dependency like JSON::Create.

benkasminbullock commented 7 months ago

Thank you for the pull request. What is the motivation for this change? The index file generated here is a means of supporting the website version of kanjivg at kanjivg.tagaini.net. So the only person who's going to run the make-index.pl or python equivalent script at the moment is the person making the website version of kanjivg. That's just me (Ben Bullock) at the moment. I suppose having this in Python might be easier for other people to run it, but nobody is doing that at the moment. Is there some other reason this needs to be in Python, like people wanting to run the index script themselves for some purpose and getting stuck on it being in Perl, and requiring a module installation?

nix6839 commented 7 months ago

Thank you for the pull request. What is the motivation for this change? The index file generated here is a means of supporting the website version of kanjivg at kanjivg.tagaini.net. So the only person who's going to run the make-index.pl or python equivalent script at the moment is the person making the website version of kanjivg. That's just me (Ben Bullock) at the moment. I suppose having this in Python might be easier for other people to run it, but nobody is doing that at the moment. Is there some other reason this needs to be in Python, like people wanting to run the index script themselves for some purpose and getting stuck on it being in Perl, and requiring a module installation?

Oh... I thought this file was used elsewhere as well. I'll go ahead and close the PR.

benkasminbullock commented 7 months ago

I don't think it's used elsewhere at the moment. Someone other than me might take over the maintenance of this repository in the future and want to keep the web version alive, so at that moment your Python script might be just what they want.

nix6839 commented 7 months ago

Anyway, thanks for maintaining such a good project!

benkasminbullock commented 1 month ago

I decided to use this and delete the Perl file, but it can't be done now from github so I had to copy and paste it. I apologise but your contribution will not show up in the logs.

Thanks for the contribution.