search

KanjiVG / kanjivg

Kanji vector graphics
http://kanjivg.tagaini.net
Other
1.05k stars 180 forks source link

Cyclical dependencies in dataset #435

Closed Fulguritude closed 6 months ago

Fulguritude commented 6 months ago

053b6 厶 0738b 王 07adc 竜 have themselves as a dependency (cycle of length 1).

0620c 戌 0620d 戍 together, have a cyclical dependency of length 2.

These are the only cycles I've found (with an arbitrary length cycle search). I'm not sure if this is intentional or not.

benkasminbullock commented 6 months ago

In the top three examples, there is an instance of the element occuring within its own data, but in all three cases that is a "radical" element, so in other words the radical is the character itself. Therefore I think the top three cases are not an issue. In the bottom two I agree with you that there is a cyclic dependency. According to the IDS data, 戌 consists of 戊 enveloping a single stroke, and 戍 is either this construction or another one with 人 on the left, so I think what we should do is to modify those two characters. For the sake of simplicity I will use 戊 as the parent element for both cases.

benkasminbullock commented 6 months ago

https://github.com/KanjiVG/kanjivg/commit/ae66a840bbd22e69375ec012b355c93fa675b148 does the things described in the previous comment.