Peer-to-peer code review

KanoCode / my-portfolio

This is a space I created for myself where I showcase my favorite projects, that I have developed or had the most contributions in.

2 stars 0 forks source link

Open MuhmmdUsama opened 2 years ago

huseyinbiyik commented 2 years ago

That's coded well and functioning but there are some small issues. Here they are,

Social media images could be button and clickable.
In terms of accessibility, the modal window close button could have a bigger clickable area.
In terms of UX contact form/message area could have a placeholder attribute instead of a ready text.
In terms of accessibility, social media links on the footer need some padding between each other.
According to Microverse requirements for the project, there should be one name input area.

nedjwab commented 2 years ago

MuhmmdUsama commented 2 years ago

Hi @KanoCode

Good job so far! There are some issues that you still need to work on but you are almost there!

[ ] Please design your project according to one of the Figmal Template
[ ] On the desktop screen right side is having more space than the left size, kindly remove the white space on the right side try to add overflow-x: hidden to your body

Screenshot 2022-04-14 093316

[ ] On the popup page mobile view there is a lot of space kindly remove the excess space beneath your buttons and remove the space between your technology labels and buttons

Screenshot 2022-04-14 102214