KanoComputing / kano-burners

SD Card burner for OSX
GNU General Public License v2.0
12 stars 11 forks source link

Switch to a simpler 'latest.json' scheme #25

Closed tombettany closed 9 years ago

tombettany commented 9 years ago

Recently there was a change with the way that the Kano build servers handled building of the Kano OS image, allowing building of 'flavour' images but also providing opportunity for refactoring. During this refactoring, the convention for naming of the generated the OS info JSON changed to reflect the new ability to produce '.zip' files of the OS. This fix resolves these troubles.

The 'latest.json' file on the server contains lots of information which can be inferred from just the server location and the image name. This file is currently being maintained manually whenever a new image is released so reducing the number of changes required is preferential. Thus in fixing the image naming convention issues, a switch to using a simpler 'latest.json' file is implemented

cc @carolineclark @pazdera @radujipa

radujipa commented 9 years ago

Looks great Tom!

Something to look out for in the future is that when there are these kinds of core changes that previous versions of the burners can't cope with, a temporary suggestion would be to have a general INTERNAL_ERROR in /src/common/error.py that explains that there was an unknown internal error and an re-downloading the burner might fix this. This ties in with https://github.com/KanoComputing/kano-burners/issues/9

tombettany commented 9 years ago

A few notes after merging:

alex5imon commented 9 years ago

Please merge :+1: